solution #868
solution #868
Conversation
There was a problem hiding this comment.
Nice work, lets make some improve for it 1.https://www.loom.com/share/529f834e36fc442584eaabe4a92d5692
2. and check out all comments and review your code again on duplicate these mistakes
| }; | ||
|
|
||
| type UserIdType = { | ||
| userId: User | null, |
There was a problem hiding this comment.
why its called userId if its whole user
src/components/UserSelector.tsx
Outdated
| const users = useContext(UserContext); | ||
| const [isOpen, setIsOpen] = useState(false); | ||
|
|
||
| const userIdContext = useContext(UserIdContext); |
There was a problem hiding this comment.
in all components you need to destructure context obj
src/App.tsx
Outdated
| const { isLoadingPosts } = useContext(ErrorContext); | ||
| const { isError } = useContext(ErrorContext); |
There was a problem hiding this comment.
why its separate destructure? its can made in one
| > | ||
| <div className="tile is-child box is-success "> | ||
| <PostDetails /> | ||
| {postDetails.postData !== null && ( |
src/components/UserSelector.tsx
Outdated
| const handleUserId | ||
| = (userId: User) => { | ||
| userIdContext.handleUserSelect(userId); | ||
| handleMenu(); | ||
| }; |
There was a problem hiding this comment.
| const handleUserId | |
| = (userId: User) => { | |
| userIdContext.handleUserSelect(userId); | |
| handleMenu(); | |
| }; | |
| const handleUserId = (userId: User) => { | |
| userIdContext.handleUserSelect(userId); | |
| handleMenu(); | |
| }; |
| {user ? ( | ||
| <span>{user.name}</span> | ||
| ) : ( | ||
| <span>Choose a user</span> | ||
| )} |
There was a problem hiding this comment.
| {user ? ( | |
| <span>{user.name}</span> | |
| ) : ( | |
| <span>Choose a user</span> | |
| )} | |
| {user | |
| ? (<span>{user.name}</span> ) | |
| : (<span>Choose a user</span>) | |
| } |
There was a problem hiding this comment.
Hi, about cleaning the form - in the task it is written "keep the name and email after the successful submit but clear a comment text;". About email in black line box - in the task, the layout of the component PostDetails
was ready and it showed the user's name, not his email.
DEMO LINK